Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add constructor to prototype #15

Merged

Conversation

lostrouter
Copy link
Contributor

now calling new Plugin().constructor.name === 'StatsWriterPlugin'

now calling new Plugin().constructor.name === 'StatsWriterPlugin'
@ryan-roemer ryan-roemer merged commit 8ea8286 into FormidableLabs:master Oct 29, 2016
@ryan-roemer
Copy link
Member

Awesome! Released in webpack-stats-plugin@0.1.4

Small nit for next time -- most OSS projects like having the version increment unchanged for community PRs so that it's easier to decide what goes where in terms of releases. No biggie here, since this is the only inflight PR we've got right now and does match expected next release of 0.1.4. Thanks!

@lostrouter lostrouter deleted the feature/use-prototype-constructor branch October 30, 2016 02:50
@lostrouter
Copy link
Contributor Author

thanks for the tip on versioning.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants